Skip to content

fix: update onboarding copy and links for default privacy settings #14971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

fix: update onboarding copy and links for default privacy settings #14971

merged 3 commits into from
May 7, 2025
+91 −7

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Apr 29, 2025 •
edited
Loading

Description

This PR updates onboarding copy and links for default privacy settings for solana accounts.

Changes:

  1. Added a new link for solana accounts in ManageNetworks
  2. Add a new link for solana accounts to AppConstants

Related issues

Fixes:

Manual testing steps

Using the beta build

  1. Go through the onboarding until you reach settings.
  2. Click into it and then go to networks.

Screenshots/Recordings

Before

Screenshot 2025-04-29 at 23 42 46

After

Screenshot 2025-04-29 at 23 38 35

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev added team-accounts No E2E Smoke Needed If the PR does not need E2E smoke test run labels Apr 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr reviewed Apr 29, 2025
View reviewed changes
@montelaidev montelaidev requested a review from gantunesr April 29, 2025 16:13
@montelaidev montelaidev enabled auto-merge April 29, 2025 19:33
@montelaidev montelaidev requested a review from a team April 30, 2025 04:48
gantunesr
gantunesr previously approved these changes May 2, 2025
View reviewed changes
@montelaidev montelaidev added this pull request to the merge queue May 2, 2025
gantunesr
gantunesr reviewed May 2, 2025
View reviewed changes
gantunesr
gantunesr reviewed May 2, 2025
View reviewed changes
@gantunesr gantunesr removed this pull request from the merge queue due to a manual request May 2, 2025
@montelaidev montelaidev changed the title fix: update onboarding copy and links for default privacy settings fix: update onboarding copy and links for default privacy settings cp-7.47.0 May 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@montelaidev montelaidev requested a review from gantunesr May 7, 2025 09:38
@montelaidev montelaidev enabled auto-merge May 7, 2025 09:38
@Tlees-MMI Tlees-MMI added No QA Needed Apply this label when your PR does not need any QA effort. QA Passed QA testing has been completed and passed and removed No QA Needed Apply this label when your PR does not need any QA effort. labels May 7, 2025
@montelaidev montelaidev changed the title fix: update onboarding copy and links for default privacy settings cp-7.47.0 fix: update onboarding copy and links for default privacy settings May 7, 2025
@montelaidev montelaidev added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit e36668e May 7, 2025
52 of 53 checks passed
@montelaidev montelaidev deleted the fix/mmmultisrp-167-mobile branch May 7, 2025 22:01
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@montelaidev @gantunesr @metamaskbot @Tlees-MMI